Messages in this thread | | | Date | Thu, 30 Apr 2015 10:06:05 +0530 | Subject | Re: [PATCH 3/3] tracing/mm: Don't trace mm_page_pcpu_drain on offline cpus | From | Preeti Murthy <> |
| |
On Wed, Apr 29, 2015 at 10:49 PM, Shreyas B Prabhu <shreyas@linux.vnet.ibm.com> wrote: > > > On Wednesday 29 April 2015 10:38 PM, Steven Rostedt wrote: >>> I am not sure if its worth the effort now. It doesn't look like any >>> other trace point apart from the above use case will benefit from it. >>> Only smbus_write and smbus_reply seem to come close. But even they need >>> separate TP_fast_assign. >> >> It shouldn't be a problem to implement. But I'm currently cleaning up >> those files, and any changes will cause nasty conflicts. >> >> Lets do this. Push the current changes as is, and when I get around to >> adding a DEFINE_EVENT_PRINT_CONDITION(), we can modify that code to use >> it. >> > Okay, sure.
Looks good then.
Reviewed-by: Preeti U Murthy <preeti@linux.vnet.ibm.com> > > Thanks, > Shreyas >
| |