lkml.org 
[lkml]   [2015]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] power: bq27x00_battery: Add missing MODULE_ALIAS
Hi,

On Tue, Apr 28, 2015 at 10:23:06PM +0200, Marek Belisko wrote:
> Without MODULE_ALIAS bq27x00_battery module won't get loaded
> automatically.
>
> Signed-off-by: Marek Belisko <marek@goldelico.com>
> ---
> drivers/power/bq27x00_battery.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/power/bq27x00_battery.c b/drivers/power/bq27x00_battery.c
> index a57433d..542927e 100644
> --- a/drivers/power/bq27x00_battery.c
> +++ b/drivers/power/bq27x00_battery.c
> @@ -1109,6 +1109,12 @@ static void __exit bq27x00_battery_exit(void)
> }
> module_exit(bq27x00_battery_exit);
>
> +#ifdef CONFIG_BATTERY_BQ27X00_PLATFORM
> +MODULE_ALIAS("platform:bq27000-battery");
> +#else
> +MODULE_ALIAS("i2c:bq27000-battery");
> +#endif
> +
> MODULE_AUTHOR("Rodolfo Giometti <giometti@linux.it>");
> MODULE_DESCRIPTION("BQ27x00 battery monitor driver");
> MODULE_LICENSE("GPL");

NAK. You should set the alias by checking for
CONFIG_BATTERY_BQ27X00_PLATFORM and CONFIG_BATTERY_BQ27X00_I2C
respectively, so that all scenarios are handled.

-- Sebastian
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-04-30 18:01    [W:0.054 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site