Messages in this thread | | | Date | Thu, 30 Apr 2015 14:51:48 +0200 | From | Daniel Borkmann <> | Subject | Re: [PATCH 0/4] Seccomp filter JIT support on ARM. |
| |
On 04/30/2015 02:35 PM, Nicolas Schichan wrote: > On 04/29/2015 06:37 PM, Daniel Borkmann wrote: >> On 04/29/2015 03:37 PM, Nicolas Schichan wrote: >> ... >>> The fourth and final patch fixes a bug in the emit_udiv() function >>> when used to convert a BPF_ALU | BPF_DIV | BPF_K instruction in the >>> ARM BPF JIT code. >> >> Shouldn't that fix go separately, so it can be included into 4.1 >> resp. -stable? > > Sure, shall I resend that separately from the v2 of the serie or is it fine in > its current form ?
Would be great if you could send that as an individual patch, since it's a stand-alone fix and independent from the (feature) patch set.
>> Would be good if you also Cc Mircea, who wrote the code. Was that >> caught by lib/test_bpf.c suite (if not, would be good to add a test >> case for it) ? > > It was detected by an internal test suite we have here. I see that there are > some BPF_ALU | BPF_DIV | BPF_K instructions so it might also be caught by > lib/test_bpf.c as well.
If there are some additional tests that are not yet covered by lib/test_bpf.c, I'd be happy if you could add them there. This can also be as a follow-up, but if we can increase coverage for others as well, the better.
Thanks again, Daniel
| |