lkml.org 
[lkml]   [2015]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] net: dsa: Fix scope of eeprom-length property
On Wed, Apr 29, 2015 at 10:56:15AM -0700, Guenter Roeck wrote:
> eeprom-length is a switch property, not a dsa property, and thus
> needs to be attached to the switch node, not to the dsa node.
>
> Reported-by: Andrew Lunn <andrew@lunn.ch>
> Fixes: 6793abb4e849 ("net: dsa: Add support for switch EEPROM access")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Acked-by: Andrew Lunn <andrew@lunn.ch?

Thanks
Andrew

> ---
> net/dsa/dsa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c
> index 079a224471e7..e6f6cc3a1bcf 100644
> --- a/net/dsa/dsa.c
> +++ b/net/dsa/dsa.c
> @@ -633,7 +633,7 @@ static int dsa_of_probe(struct device *dev)
> if (cd->sw_addr > PHY_MAX_ADDR)
> continue;
>
> - if (!of_property_read_u32(np, "eeprom-length", &eeprom_len))
> + if (!of_property_read_u32(child, "eeprom-length", &eeprom_len))
> cd->eeprom_len = eeprom_len;
>
> for_each_available_child_of_node(child, port) {
> --
> 2.1.0
>


\
 
 \ /
  Last update: 2015-04-29 20:41    [W:0.035 / U:0.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site