Messages in this thread | | | Date | Tue, 28 Apr 2015 22:42:40 -0700 | Subject | Re: [PATCH 02/10] block: simplify bio_add_page() | From | Ming Lin <> |
| |
On Tue, Apr 28, 2015 at 5:12 AM, Christoph Hellwig <hch@lst.de> wrote: > On Mon, Apr 27, 2015 at 11:48:29PM -0700, Ming Lin wrote: >> Note that removing call to ->merge_bvec_fn() is fine for >> bio_add_pc_page(), as SCSI devices usually don't even need that. >> Few exceptional cases like pscsi or osd are not affected either. > > This explanation confuses me. Based on my reading of the code I'd > replace it with something like: > > Removing the call to ->merge_bvec_fn() is also fine, as no driver that > implements support for BLOCK_PC commands even has a ->merge_bvec_fn() > method.
Will update it.
| |