Messages in this thread | | | Date | Wed, 29 Apr 2015 11:55:02 +0100 | From | Lee Jones <> | Subject | Re: [PATCH RESEND] mfd: arizona: Remove redundant register sync |
| |
On Wed, 22 Apr 2015, Charles Keepax wrote:
> This soft reset used to be located after the register patch had been > applied, but has since moved to before the patch is applied. At the new > location there is no requirement to do a register sync as no register > writes will have happened yet. > > Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> > --- > drivers/mfd/arizona-core.c | 8 -------- > 1 files changed, 0 insertions(+), 8 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c > index 6ca6dfa..aed43a5 100644 > --- a/drivers/mfd/arizona-core.c > +++ b/drivers/mfd/arizona-core.c > @@ -777,8 +777,6 @@ int arizona_dev_init(struct arizona *arizona) > > /* If we have a /RESET GPIO we'll already be reset */ > if (!arizona->pdata.reset) { > - regcache_mark_dirty(arizona->regmap); > - > ret = regmap_write(arizona->regmap, ARIZONA_SOFTWARE_RESET, 0); > if (ret != 0) { > dev_err(dev, "Failed to reset device: %d\n", ret); > @@ -786,12 +784,6 @@ int arizona_dev_init(struct arizona *arizona) > } > > msleep(1); > - > - ret = regcache_sync(arizona->regmap); > - if (ret != 0) { > - dev_err(dev, "Failed to sync device: %d\n", ret); > - goto err_reset; > - } > } > > /* Ensure device startup is complete */
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |