Messages in this thread | | | Date | Wed, 29 Apr 2015 13:02:49 +0300 | From | Mika Westerberg <> | Subject | Re: [PATCH 2/2] i2c / ACPI: Assign IRQ for devices that have GpioInt automatically |
| |
On Wed, Apr 29, 2015 at 11:56:06AM +0200, Wolfram Sang wrote: > > > - if (!client->irq && dev->of_node) { > > - int irq = of_irq_get(dev->of_node, 0); > > + if (client->irq <= 0) { > > + int irq = -ENOENT; > > Why the move from !client->irq to <= 0? If I didn't miss something, > interrupt numbers are still a sleeping dog with all the unsigned vs > signed fuzz. If this change is needed, this needs proper description and > ideally a seperate patch.
It is there because ACPI parts of I2C client enumeration code initializes client->irq with -1. Alternatively we can change that code to use 0 for missing IRQ.
| |