lkml.org 
[lkml]   [2015]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] i2c / ACPI: Assign IRQ for devices that have GpioInt automatically
On Wed, Apr 29, 2015 at 11:56:06AM +0200, Wolfram Sang wrote:
>
> > - if (!client->irq && dev->of_node) {
> > - int irq = of_irq_get(dev->of_node, 0);
> > + if (client->irq <= 0) {
> > + int irq = -ENOENT;
>
> Why the move from !client->irq to <= 0? If I didn't miss something,
> interrupt numbers are still a sleeping dog with all the unsigned vs
> signed fuzz. If this change is needed, this needs proper description and
> ideally a seperate patch.

It is there because ACPI parts of I2C client enumeration code
initializes client->irq with -1. Alternatively we can change that code
to use 0 for missing IRQ.


\
 
 \ /
  Last update: 2015-04-29 12:21    [W:0.042 / U:0.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site