lkml.org 
[lkml]   [2015]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drivers/nfc: remove obsolete setting of DEBUG
From
Date
On Wed, 2015-04-29 at 10:45 +0200, Valentin Rothberg wrote:
> Thanks, I was not aware of it at all. I read the code and it seems
> that if neither DYNAMIC_DEBUG nor DEBUG is defined, pr_debug() does
> nothing more than to return 0.
>
> I am not sure what to do in this case. Somehow it seems reasonable to
> me to add NFC_DEBUG to Kconfig since a considerable amount of code in
> nfc seems to depend on DEBUG.

A few greps tell me the first pointless reference to CONFIG_NFC_DEBUG
was added in v3.1. So clearly the people actually building and using the
nfc code don't need the DEBUG flag. Apparently using pr_debug() by
setting CONFIG_DYNAMIC_DEBUG works for them. (I trust Joe will shout
when that statement is incorrect.)

So, as I said, the patch should be fine, and only the commit explanation
needs work.


Paul Bolle



\
 
 \ /
  Last update: 2015-04-29 11:21    [W:0.487 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site