Messages in this thread | | | Subject | Re: [PATCH v4] extcon-axp288: Add axp288 extcon driver support | From | Paul Bolle <> | Date | Tue, 28 Apr 2015 09:41:46 +0200 |
| |
Only a license nit.
On Tue, 2015-04-28 at 04:02 +0530, Ramakrishna Pallala wrote: > --- /dev/null > +++ b/drivers/extcon/extcon-axp288.c
> + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details.
This states the license is GPL v2 or later.
> +MODULE_LICENSE("GPL v2");
And, according to include/linux/module.h, this states the license is (just) GPL v2. So I think that either the comment at the top of this file or the ident used in the MODULE_LICENSE() macro should be changed.
Thanks,
Paul Bolle
| |