Messages in this thread | | | From | Valentin Rothberg <> | Date | Tue, 28 Apr 2015 18:49:10 +0200 | Subject | Re: [PATCH] arch/arm/mach-mvebu/Kconfig: remove obsolete selects |
| |
Hi Gregory,
thanks for your reply.
On Tue, Apr 28, 2015 at 6:41 PM, Gregory CLEMENT <gregory.clement@free-electrons.com> wrote: > Hi Valentin, > > On 28/04/2015 18:02, Valentin Rothberg wrote: >> ARM_ERRATA_753970 is not defined in Kconfig, so that both selects turn >> out to be nops. Hence, we can safely remove them. > > It was already pointed by Paul Bolle a few months ago: > http://thread.gmane.org/gmane.linux.kernel/1868817 > > and I thought it was applied. > > He pointed that the original intent was to select > PL310_ERRATA_753970. Initially I was not sure if we needed it. In the > meantime I didn't get any answer from the hardware designers but this > errata affects the r3p0 version and according to the Cache ID register > the PL310 used on these two SoCs were the r3p3.
I should have checked my mails before (Paul put me in the CC for this patch).
Kind regards, Valentin
> At the end I don't know which one of the patches to apply... > > But in any case I will add > Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com> > > > Thanks, > > Gregory > > >> >> Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com> >> --- >> I detected this issue with scripts/checkkconfigsymbols.py >> --- >> arch/arm/mach-mvebu/Kconfig | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig >> index 97473168d6b6..b9f1b63b169c 100644 >> --- a/arch/arm/mach-mvebu/Kconfig >> +++ b/arch/arm/mach-mvebu/Kconfig >> @@ -37,7 +37,6 @@ config MACH_ARMADA_370 >> config MACH_ARMADA_375 >> bool "Marvell Armada 375 boards" if ARCH_MULTI_V7 >> select ARM_ERRATA_720789 >> - select ARM_ERRATA_753970 >> select ARM_GIC >> select ARMADA_375_CLK >> select HAVE_ARM_SCU >> @@ -52,7 +51,6 @@ config MACH_ARMADA_375 >> config MACH_ARMADA_38X >> bool "Marvell Armada 380/385 boards" if ARCH_MULTI_V7 >> select ARM_ERRATA_720789 >> - select ARM_ERRATA_753970 >> select ARM_GIC >> select ARMADA_38X_CLK >> select HAVE_ARM_SCU >> > > > -- > Gregory Clement, Free Electrons > Kernel, drivers, real-time and embedded Linux > development, consulting, training and support. > http://free-electrons.com
| |