Messages in this thread | | | From | Kevin Hilman <> | Subject | Re: [PATCH 0/3] Introduce SET_NOIRQ_SYSTEM_SLEEP_PM_OPS and use it | Date | Tue, 28 Apr 2015 08:40:04 -0700 |
| |
<grygorii.strashko@linaro.org> writes:
> From: Grygorii Strashko <grygorii.strashko@linaro.org> > > While working on suspend-to-disk functionality on TI dra7-evm (DRA7xx SoC) > i've found that the most common problem I have to dial with is absence > of corresponding PM callbacks in drivers and, in particular, noirq callbacks. > So, I've fixed one driver first > commit 6248015d6867 "ARM: omap-device: add missed callback for suspend-to-disk" > but then found another one which need to be fixed too (omap_l3_noc.c). > At this moment I decided to make my life easier and added new macro > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS using the same approach as for the existing > SET_SYSTEM_SLEEP_PM_OPS macro. > > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS: defined for CONFIG_PM_SLEEP and > assigns ->suspend_noirq, ->freeze_noirq and ->poweroff_noirq to the same > function. Vice versa happens for ->resume_noirq, ->thaw_noirq and > ->restore_noirq. > > Further two patches reuse this newly introduced macro. > > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS, defined for CONFIG_PM_SLEEP, will > point ->suspend_noirq, ->freeze_noirq and ->poweroff_noirq to the same > function. Vice versa happens for ->resume_noirq, ->thaw_noirq and > ->restore_noirq.
For the series:
Reviewed-by: Kevin Hilman <khilman@linaro.org>
And for the omap_device changes:
Acked-by: Kevin Hilman <khilman@linaro.org>
| |