lkml.org 
[lkml]   [2015]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 02/64] perf diff: Make hist_entry_diff fields union
    Date
    From: Namhyung Kim <namhyung@kernel.org>

    The period_ratio_delta, period_ratio and wdiff are never by used at the
    same time. Instead, Just one of them is accessed according to a
    comparison method. So make it union to reduce memory footprint.

    Signed-off-by: Namhyung Kim <namhyung@kernel.org>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Link: http://lkml.kernel.org/r/1429416255-12070-3-git-send-email-namhyung@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/util/sort.h | 15 ++++++++-------
    1 file changed, 8 insertions(+), 7 deletions(-)

    diff --git a/tools/perf/util/sort.h b/tools/perf/util/sort.h
    index af192f172fa2..de3303fe726d 100644
    --- a/tools/perf/util/sort.h
    +++ b/tools/perf/util/sort.h
    @@ -58,15 +58,16 @@ struct he_stat {

    struct hist_entry_diff {
    bool computed;
    + union {
    + /* PERF_HPP__DELTA */
    + double period_ratio_delta;

    - /* PERF_HPP__DELTA */
    - double period_ratio_delta;
    -
    - /* PERF_HPP__RATIO */
    - double period_ratio;
    + /* PERF_HPP__RATIO */
    + double period_ratio;

    - /* HISTC_WEIGHTED_DIFF */
    - s64 wdiff;
    + /* HISTC_WEIGHTED_DIFF */
    + s64 wdiff;
    + };
    };

    /**
    --
    1.9.3


    \
     
     \ /
      Last update: 2015-04-28 15:41    [W:3.385 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site