Messages in this thread | | | Date | Tue, 28 Apr 2015 14:23:43 +0200 | Subject | Re: [PATCH 01/11] coresight-etm4x: Adding CoreSight ETM4x driver | From | Linus Walleij <> |
| |
On Fri, Apr 24, 2015 at 5:41 PM, Ivan T. Ivanov <iivanov@mm-sol.com> wrote: > On Wed, 2015-04-22 at 16:40 -0600, Mathieu Poirier wrote: >> > >> +static struct amba_id etm4_ids[] = { >> + { /* ETM 4.0 - Hi6220 board */ >> + .id = 0x0003b95d, >> + .mask = 0x0003ffff, >> + .data = "ETM 4.0", >> + }, >> + { /* ETM 4.0 - Juno board */ >> + .id = 0x000bb95e, >> + .mask = 0x000bffff, > > Mask looks suspicious.
I'm thinking that maybe we should have some masks predefined in <linux/amba/bus.h> for bits in this field so we get it right.
Yours, Linus Walleij
| |