Messages in this thread | | | Date | Mon, 27 Apr 2015 23:49:18 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH 3/3 V8] workqueue: Allow modifying low level unbound workqueue cpumask |
| |
Hello,
On Tue, Apr 28, 2015 at 10:24:31AM +0800, Lai Jiangshan wrote: > >> Wouldn't this make a lot more sense above when copying @attrs into > >> @new_attrs? The comment there even says "make a copy of @attrs and > >> sanitize it". Copy to @new_attrs, mask with wq_unbound_cpumask and > >> fall back to wq_unbound_cpumask if empty. > > We need to save the user original configured attrs. > When any time wq_unbound_cpumask is changed, we should use > the user original configured attrs (cpumask) to re-calculate > the pwqs and avoid losing any information.
Sure, we can do that for new_attrs and then mask tmp_attrs further w/ wq_unbound_cpumask, no?
Thanks.
-- tejun
| |