lkml.org 
[lkml]   [2015]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] livepatch: x86: make kASLR logic more accurate
On 04/28/15 at 01:29P, Jiri Kosina wrote:
> On Mon, 27 Apr 2015, Minfei Huang wrote:
>
> > Found that kaslr_enabled is only exist for x86. Maybe you can define a
> > weak function klp_adjustment_function_addr in general. Then each arch
> > can overwrite the function to implemente it specially.
>
> It might start to make sense once there is at least one additional arch
> that supports kaslr. Currently, I don't see a benefit.
>
> Why are you so obstinate about this? I personally don't find that
> important at all; it's something that can always be sorted out once more
> archs start supporting kaslr.
>

ohhh... Previously, IMO, putting the relevant function address adjustment
into the specified arch is more clearly to be reviewed and understood.

Now, I know what you actual want according to above commit, I am fine
with it.

Thanks
Minfei

> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
> --
> To unsubscribe from this list: send the line "unsubscribe live-patching" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html


\
 
 \ /
  Last update: 2015-04-28 02:41    [W:0.039 / U:1.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site