| Date | Mon, 27 Apr 2015 22:36:08 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 01/13] thermal: Make temperatures consistently unsigned long |
| |
On Thu 2015-03-26 16:53:48, Sascha Hauer wrote: > The thermal framework uses int, long and unsigned long for temperatures > in millicelsius. The majority of functions uses unsigned long, so change > the remaining functions to use this type aswell.
Maybe millicelsius_t should be introduced, so that readers immediately know what type it is? Some parts of kernel also use decicelsius and decikelvin, IIRC (ACPI).
Pavel
> if (trip_type == THERMAL_TRIP_CRITICAL) { > dev_emerg(&tz->device, > - "critical temperature reached(%d C),shutting down\n", > + "critical temperature reached(%lu C),shutting down\n",
space after , ?
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
|