Messages in this thread Patch in this message | | | From | Johannes Weiner <> | Subject | [PATCH 5/9] mm: oom_kill: remove unnecessary locking in exit_oom_victim() | Date | Mon, 27 Apr 2015 15:05:51 -0400 |
| |
Disabling the OOM killer needs to exclude allocators from entering, not existing victims from exiting.
Right now the only waiter is suspend code, which achieves quiescence by disabling the OOM killer. But later on we want to add waits that hold the lock instead to stop new victims from showing up.
Signed-off-by: Johannes Weiner <hannes@cmpxchg.org> Acked-by: Michal Hocko <mhocko@suse.cz> --- mm/oom_kill.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/mm/oom_kill.c b/mm/oom_kill.c index 472f124..d3490b0 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -437,10 +437,8 @@ void exit_oom_victim(void) { clear_thread_flag(TIF_MEMDIE); - down_read(&oom_sem); if (!atomic_dec_return(&oom_victims)) wake_up_all(&oom_victims_wait); - up_read(&oom_sem); } /** -- 2.3.4
| |