Messages in this thread | | | From | "Nicolae, Anda-maria" <> | Subject | RE: [PATCH] power_supply: Add support for Richtek rt9455 battery charger | Date | Mon, 27 Apr 2015 13:00:11 +0000 |
| |
Hello Paul,
Thanks for feedback :). I understand. I will change the license to GPL.
Thanks, Anda
________________________________________ From: Paul Bolle [pebolle@tiscali.nl] Sent: Saturday, April 25, 2015 12:00 PM To: Nicolae, Anda-maria Cc: sre@kernel.org; dbaryshkov@gmail.com; robh+dt@kernel.org; pawel.moll@arm.com; mark.rutland@arm.com; ijc+devicetree@hellion.org.uk; galak@codeaurora.org; dwmw2@infradead.org; linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org; devicetree@vger.kernel.org Subject: Re: [PATCH] power_supply: Add support for Richtek rt9455 battery charger
Just a single nit: a license mismatch.
On Fri, 2015-04-24 at 10:57 +0300, Anda-Maria Nicolae wrote: > --- /dev/null > +++ b/drivers/power/rt9455_charger.c
> + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details.
This states the license is GPL v2 or later.
> +MODULE_LICENSE("GPL v2");
And, according to include/linux/module.h, this states the license is (only) GPL v2. So I think either the license comment or the ident used in the MODULE_LICENSE() macro should be changed.
Paul Bolle
| |