Messages in this thread | | | Date | Mon, 27 Apr 2015 17:46:37 +0900 | From | Chanwoo Choi <> | Subject | Re: [PATCH v2] clk: Show clock rate and error value when fail to set clock rate |
| |
Hi Sylwester,
On 04/21/2015 05:37 PM, Sylwester Nawrocki wrote: > Hi Chanwoo, > > On 20/04/15 13:08, Chanwoo Choi wrote: >> This patch shows the current clock rate nad error value when clk_set_rate() >> fail to set the clock rate because log messgae means only the clock rate. >> >> Cc: Mike Turquette <mturquette@linaro.org> >> Cc: Stephen Boyd <sboyd@codeaurora.org> >> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >> --- >> Changes from v1: >> - Add error value of clk-set_rate() with current clock rate >> >> drivers/clk/clk-conf.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/clk/clk-conf.c b/drivers/clk/clk-conf.c >> index aad4796..2b6375f 100644 >> --- a/drivers/clk/clk-conf.c >> +++ b/drivers/clk/clk-conf.c >> @@ -107,8 +107,9 @@ static int __set_clk_rates(struct device_node *node, bool clk_supplier) >> >> rc = clk_set_rate(clk, rate); >> if (rc < 0) >> - pr_err("clk: couldn't set %s clock rate: %d\n", >> - __clk_get_name(clk), rc); >> + pr_err("clk: couldn't set %s rate to %ld (%d)\n", >> + __clk_get_name(clk), clk_get_rate(clk), >> + rc); > > Apologies for my previous misleading comment, with this patch > you log current clock rate as the rate which was attempted to > be set. And these two will likely be different when clk_set_rate() > failed. So it should rather be: > > pr_err("clk: couldn't set %s clk rate to %ld (%d)\n", > __clk_get_name(clk), rate, rc);
I'll modify it as following without error value. If I add the error value, the number of character are over 80. pr_err("clk: couldn't set %s clk rate to %ld\n", __clk_get_name(clk), rate);
Thanks, Chanwoo Choi
| |