lkml.org 
[lkml]   [2015]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 3/4] ASoC: tas571x: New driver for TI TAS571x power amplifiers
On Fri, Apr 24, 2015 at 03:36:47PM -0700, Kevin Cernekee wrote:

> + gpiod_set_value(priv->pdn_gpio, 0);
> + usleep_range(5000, 6000);
> +
> + regcache_cache_only(priv->regmap, false);
> + ret = regcache_sync_region(priv->regmap, 0,
> + priv->chip->regmap_config->max_register, false);
> + if (ret)
> + return ret;

This is also a problem with your first patch BTW - even if we are going
to add an argument we shouldn't be having drivers do _sync_region() to
sync the entire register map, that's just ugly.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-04-25 13:41    [W:0.064 / U:0.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site