lkml.org 
[lkml]   [2015]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] xillybus: XILLYBUS_OF should depend on HAS_DMA
From
Hi Eli,

On Fri, Apr 24, 2015 at 2:42 PM, Eli Billauer <eli.billauer@gmail.com> wrote:
> Thanks for this. The dependency on HAS_DMA is obviously missing (is there
> any real platform that uses OF but has HAS_DMA off? Sounds a bit esoteric to
> me).

I hit this with the patch that allows to enable OF if COMPILE_TEST, which
will probably be accepted soon.

> And if we're at it, I now realize that XILLYBUS_PCIE maybe also should
> depend on HAS_DMA, in case PCI is enabled but HAS_DMA isn't...?

PCI is only available on platform that set HAS_DMA.

> I don't maintain a git repository of my own -- Greg applies my patches into
> char-next when I have any (doesn't happen very often). So I suppose this
> should be Cced to the maintainers of "CHAR and MISC DRIVERS" (that is, Greg
> and Arnd). Preferably with a "char: xillybus:" prefix in the title, I guess.

I've just used get_maintainer.pl, so please update MAINTAINERS.

Can I add your Acked-by, then I can send an updated version to Greg and Arnd?

Thanks!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


\
 
 \ /
  Last update: 2015-04-24 15:41    [W:4.049 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site