lkml.org 
[lkml]   [2015]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] watchdog: Fix watchdog_nmi_enable_all()
> ----- Original Message -----
> From: "Andrew Morton" <akpm@linux-foundation.org>
> To: "Don Zickus" <dzickus@redhat.com>
> Cc: "LKML" <linux-kernel@vger.kernel.org>, "Ulrich Obergfell" <uobergfe@redhat.com>
> Sent: Wednesday, April 22, 2015 10:12:01 PM
> Subject: Re: [PATCH] watchdog: Fix watchdog_nmi_enable_all()
>
> On Wed, 22 Apr 2015 10:47:49 -0400 Don Zickus <dzickus@redhat.com> wrote:
>
>> From: Ulrich Obergfell <uobergfe@redhat.com>
>>
>> The 'watchdog_user_enabled' variable is only used as an 'interface'
>> to the /proc/sys/kernel/watchdog parameter. The actual state of the
>> watchdog is tracked by bits in the 'watchdog_enabled' variable. So,
>> watchdog_nmi_enable_all() should check the NMI_WATCHDOG_ENABLED bit
>> in 'watchdog_enabled'.
>
> What are the user-visible effects of the patch? Please always include
> this information when fixing a bug.

Andrew,

this patch has no user-visible effects. The issue that is addressed by this
patch came up during the recent merges. It is related to:

1) https://lkml.org/lkml/2015/2/5/624
2) http://lkml.kernel.org/r/1416251225-17721-12-git-send-email-eranian@google.com

Patch series 1) changes the way how the code in kernel/watchdog.c uses certain
variables such as 'watchdog_user_enabled' and it also introduces a new variable
'watchdog_enabled' as described in:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/kernel/watchdog.c?id=84d56e66b9b4a646f04ec30696ca1aeea5e654d5

This patch adjusts patch 2) which introduces watchdog_nmi_enable_all() to the
new way how the code in kernel/watchdog.c should use 'watchdog_user_enabled'
and 'watchdog_enabled'. Patch 2) is here:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/kernel/watchdog.c?id=b3738d29323344da3017a91010530cf3a58590fc


Regards,

Uli


\
 
 \ /
  Last update: 2015-04-23 10:41    [W:0.051 / U:3.776 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site