lkml.org 
[lkml]   [2015]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 22/27] IB/Verbs: Use management helper cap_ipoib()


    On 04/22/2015 07:24 PM, Jason Gunthorpe wrote:
    > On Wed, Apr 22, 2015 at 10:49:44AM +0200, Michael Wang wrote:
    >>
    >> On 04/22/2015 07:40 AM, Jason Gunthorpe wrote:
    >>> On Mon, Apr 20, 2015 at 10:41:38AM +0200, Michael Wang wrote:
    >>>
    >>>> Introduce helper cap_ipoib() to help us check if the port of an
    >>>> IB device support IP over Infiniband.
    >>>
    >>> I thought we were dropping this in favor of listing the actual
    >>> features the ULP required unconditionally? One of my messages had the
    >>> start of a list..
    >>
    >> Shall we drop it now or wait until the mechanism introduced?
    >>
    >> Just wondering the requirement of ULP could be similar to the
    >> requirement of management, isn't it? if the device can tell
    >> which ULP it support, then may be a cap_XX() make sense in here?
    >
    > You have to audit the ipoib dirver and see what core functions it
    > calls that have cap requirements themselves.
    >
    > At least SA, multicast and CM. It also requires cap_ib_ah() or
    > whatever we called that.

    I get your point :-) I'd like to suggest we put these in different threads:

    1. bitmask reform
    2. ulp check mechanism
    3. naming (i think it'll be a really big discussion :-P)

    Separate them can help us focus on a particular topic at once, and the
    purpose of patches will be more clear ;-)

    Regards,
    Michael Wang

    >
    > JAson
    >


    \
     
     \ /
      Last update: 2015-04-23 10:21    [W:3.795 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site