lkml.org 
[lkml]   [2015]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/3] of: Allow OF to be enabled if COMPILE_TEST to increase coverage
From
Date
Hi Rob,

> On Apr 23, 2015, at 21:22 , Rob Herring <robherring2@gmail.com> wrote:
>
> On Thu, Apr 23, 2015 at 7:03 AM, Pantelis Antoniou
> <pantelis.antoniou@konsulko.com> wrote:
>> Hi Rob,
>>
>>> On Apr 6, 2015, at 16:13 , Rob Herring <robherring2@gmail.com> wrote:
>>>
>>> +Pantelis
>>>
>>> On Sun, Apr 5, 2015 at 9:59 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>>>> Currently the OF configuration symbol is explicitly selected on
>>>> architectures that support device trees and/or Open Firmware.
>>>> However, there's no technical reason to limit the device tree
>>>> infrastructure to these architectures. Hence allow OF to be enabled when
>>>> compile testing, to increase compile coverage.
>>>>
>>>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>>>> ---
>>>> drivers/of/Kconfig | 6 +++++-
>>>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
>>>> index 7bcaeec876c0c3a5..4c98f14694458794 100644
>>>> --- a/drivers/of/Kconfig
>>>> +++ b/drivers/of/Kconfig
>>>> @@ -2,7 +2,11 @@ config DTC
>>>> bool
>>>>
>>>> config OF
>>>> - bool
>>>> + bool "Device Tree and Open Firmware support" if COMPILE_TEST
>>>
>>> Actually, I think we want to just make this always visible. There are
>>> now use cases with overlays where we may want to enable DT even if the
>>> architecture is not booting with DT. However, there may be more work
>>> needed to do that.
>>>
>>
>> We have to decouple the notion of CONFIG_OF of the following two different things.
>>
>> 1. I’m booting using a device tree blob.
>> 2. I’m using the in-kernel live device tree to represent my hardware device state.
>>
>> so CONFIG_OF_DTB_BLOB for the first case, and CONFIG_OF for the second.
>>
>> Up to now we bundle those two together.
>
> They are separate already with CONFIG_OF_EARLY_FLATTREE
>

A bit cryptically named, no?

> Rob

Regards

— Pantelis



\
 
 \ /
  Last update: 2015-04-23 20:41    [W:0.051 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site