Messages in this thread | | | Date | Thu, 23 Apr 2015 23:13:34 +0900 | Subject | Re: [PATCH] lib/scatterlist: fix kerneldoc for sg_pcopy_{to,from}_buffer() | From | Akinobu Mita <> |
| |
2015-04-23 22:57 GMT+09:00 Dave Gordon <david.s.gordon@intel.com>: > The kerneldoc for the functions doesn't match the code; the > last two parameters (buflen, skip) have been transposed, which > is confusing, especially as they're both integral types and the > compiler won't warn about swapping them. > > These functions and the kerneldoc were introduced in commit: > df642cea lib/scatterlist: introduce sg_pcopy_from_buffer() ... > Author: Akinobu Mita <akinobu.mita@gmail.com> > Date: Mon Jul 8 16:01:54 2013 -0700 > > The only difference between sg_pcopy_{from,to}_buffer() and > sg_copy_{from,to}_buffer() is an additional argument that > specifies the number of bytes to skip the SG list before > copying.
Thanks for fixing this.
Reviewed-by: Akinobu Mita <akinobu.mita@gmail.com>
| |