lkml.org 
[lkml]   [2015]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] lib/scatterlist: fix kerneldoc for sg_pcopy_{to,from}_buffer()
From
2015-04-23 22:57 GMT+09:00 Dave Gordon <david.s.gordon@intel.com>:
> The kerneldoc for the functions doesn't match the code; the
> last two parameters (buflen, skip) have been transposed, which
> is confusing, especially as they're both integral types and the
> compiler won't warn about swapping them.
>
> These functions and the kerneldoc were introduced in commit:
> df642cea lib/scatterlist: introduce sg_pcopy_from_buffer() ...
> Author: Akinobu Mita <akinobu.mita@gmail.com>
> Date: Mon Jul 8 16:01:54 2013 -0700
>
> The only difference between sg_pcopy_{from,to}_buffer() and
> sg_copy_{from,to}_buffer() is an additional argument that
> specifies the number of bytes to skip the SG list before
> copying.

Thanks for fixing this.

Reviewed-by: Akinobu Mita <akinobu.mita@gmail.com>


\
 
 \ /
  Last update: 2015-04-23 16:41    [W:0.036 / U:1.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site