Messages in this thread | | | Date | Wed, 22 Apr 2015 07:30:54 -0700 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH tip/core/rcu 11/12] rcu: Make RCU able to tolerate undefined CONFIG_RCU_FANOUT_LEAF |
| |
On Wed, Apr 22, 2015 at 01:25:07AM -0400, Pranith Kumar wrote: > On Tue, Apr 21, 2015 at 3:55 PM, Paul E. McKenney > <paulmck@linux.vnet.ibm.com> wrote: > > > diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h > > index 2e52502bfc95..a2f64e4fdb57 100644 > > --- a/kernel/rcu/tree_plugin.h > > +++ b/kernel/rcu/tree_plugin.h > > @@ -86,10 +86,10 @@ static void __init rcu_bootup_announce_oddness(void) > > pr_info("\tAdditional per-CPU info printed with stalls.\n"); > > if (RCU_NUM_LVLS >= 4) > > pr_info("\tFour(or more)-level hierarchy is enabled.\n"); > > - if (CONFIG_RCU_FANOUT_LEAF != 16) > > + if (RCU_FANOUT_LEAF != 16) > > So if CONFIG_RCU_FANOUT_LEAF is either by default 32 or 64, this check > against 16 for build-time adjustment is a bit misleading, no?
Indeed!
However, with the fix that puts the default back to 16, this should be once again correct.
Thanx, Paul
| |