Messages in this thread | | | Date | Wed, 22 Apr 2015 12:27:55 +0200 | From | Paolo Bonzini <> | Subject | Re: [PATCH] KVM: x86: tweak types of fields in kvm_lapic_irq |
| |
On 22/04/2015 11:35, Radim Krčmář wrote: > > Change the level field to bool, since we assign 1 sometimes, but > > just mask icr_low with APIC_INT_ASSERT in apic_send_-ipi. > > Would be more consistent to change that assignment instead ... > If we dropped the idea that struct kvm_lapic_irq fields can be bitORed > to get the ICR, we could also easily change trig_mode/dest_mode to bool > level_trig/logical_dest. (I can do a followup patch.)
Right, I thought of both. However, level is something that has an obviously understandable meaning as a bool, while trig_mode/dest_mode as you said have to be renamed as well.
You're right on the u8 type for vector, too. But I probably will end up not committing this patch at all...
Paolo
| |