Messages in this thread | | | Date | Mon, 20 Apr 2015 13:50:38 -0700 | Subject | Re: [LKP] [ocfs2] e2ac55b6a8e: ocfs2_init:1612 ERROR: Unable to create ocfs2 debugfs root | From | Linus Torvalds <> |
| |
On Sun, Apr 19, 2015 at 8:45 PM, Chengyu Song <csong84@gatech.edu> wrote: > > As suggested in the patch, -19 (-ENODEV) happens when debugfs is not configured (see include/linux/debugfs.h). So if debugfs is necessary for the functionality, in Kconfig, we should either declare it as a dependency, or auto select it.
That makes no sense.
If it used to work before that patch, then this is a regression and the patch needs to be reverted.
Yes, the old code apparently used to set "o2hb_debug_dir" to an error pointer when debugfs was compiled out, but since debugfs was compiled out, that error pointer was probably never actually *used*. So things presumably worked.
Now, it hangs, according to Huang Ying. If so, that's clearly a regression. That means that commit e2ac55b6a8e3 ("ocfs2: incorrect check for debugfs returns") needs to be reverted or fixed.
Andrew?
Linus
| |