Messages in this thread | | | Date | Mon, 20 Apr 2015 10:20:02 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 3/7] perf tools: Move TUI-specific fields to struct hist_entry_tui |
| |
On Sun, Apr 19, 2015 at 01:04:11PM +0900, Namhyung Kim wrote: > Since perf diff only support stdio output, TUI fields are only accessed > from perf report (or perf top). So add new struct hist_entry_tui and > move those fields into them. And include it as an union member. >
SNIP
> > - /* XXX These two should move to some tree widget lib */ > - u16 row_offset; > - u16 nr_rows; > - > bool init_have_children; > char level; > u8 filtered; > + union { > + struct hist_entry_diff diff; > + struct hist_entry_tui tui; > + };
could you please add the comment from changelog in here, so it's easy to figure this out in the future
thanks, jirka
| |