lkml.org 
[lkml]   [2015]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] mtd: Add simple read disturb test
    Am 02.04.2015 um 18:04 schrieb Brian Norris:
    > On Thu, Apr 02, 2015 at 04:13:46PM +0200, Richard Weinberger wrote:
    >> This simple MTD tests allows the user to see when read disturb happens.
    >> By reading blocks over and over it reports flipped bits.
    >> Currently it reports only flipped bits of the worst page of a block.
    >> If within block X page P1 has 3 bit flips and P6 4, it will report 4.
    >> By default every 50th block is read.
    >
    > Didn't read through this much yet, but why do we need another in-kernel
    > test that coul (AFAICT) be easily replicated in userspace? The same goes
    > for several of the other tests, I think, actually. But at least with
    > those, we have a history of keeping them around, so it's not too much
    > burden [1].

    I've added the test to drivers/mtd/tests/ because it fits into.
    As simple as that.

    > Brian
    >
    > [1] Although there are some latent issues in these tests that are still
    > getting get worked out (e.g., bad handling of 64-bit casting; too large
    > of stacks; uninterruptibility). The latter two would not even exist if
    > we were in user space.

    uninterruptibility got solved by my "[PATCH] mtd: Make MTD tests cancelable" patch.

    But if we want to kill drivers/mtd/tests/ I'll happily help out.
    Where shall we move these tests into? mtd-utils?

    Thanks,
    //richard


    \
     
     \ /
      Last update: 2015-04-02 19:01    [W:4.090 / U:0.472 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site