Messages in this thread | | | Date | Sat, 18 Apr 2015 22:45:36 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 6/7] perf data: Fix duplicate field names and avoid reserved keywords |
| |
On Sat, Apr 18, 2015 at 02:56:00PM -0400, Jérémie Galarneau wrote: > On Sat, Apr 18, 2015 at 11:50 AM, Jiri Olsa <jolsa@kernel.org> wrote: > > From: Wang Nan <wangnan0@huawei.com> > > > > Some parameters of syscall tracepoints named as 'nr', 'event', etc. > > When dealing with them, perf convert to ctf meets some problem: > > > > 1. If a parameter with name 'nr', it will duplicate syscall's > > common field 'nr'. One such syscall is io_submit(). > > > > 2. If a parameter with name 'event', it is denied to be inserted > > because 'event' is a babeltrace keywork. One such syscall is > > epoll_ctl. > > Minor nitpick: "event" is a reserved keyword in the CTF specification > [1], the rule is only enforced by Babeltrace. Also, keywork -> > keyword.
thanks,
Arnaldo, any chance you could change it? (with ack from He Kuang of course), or do you need a respin..
jirka
| |