lkml.org 
[lkml]   [2015]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 03/17] crypto: talitos - talitos_ptr renamed ptr for more lisibility
Le 17/04/2015 17:14, David Laight a écrit :
> From: Christophe Leroy
>> Linux CodyingStyle recommends to use short variables for local
>> variables. ptr is just good enough for those 3 lines functions.
>> It helps keep single lines shorter than 80 characters.
> ...
>> -static void to_talitos_ptr(struct talitos_ptr *talitos_ptr, dma_addr_t dma_addr)
>> +static void to_talitos_ptr(struct talitos_ptr *ptr, dma_addr_t dma_addr)
>> {
>> - talitos_ptr->ptr = cpu_to_be32(lower_32_bits(dma_addr));
>> - talitos_ptr->eptr = upper_32_bits(dma_addr);
>> + ptr->ptr = cpu_to_be32(lower_32_bits(dma_addr));
>> + ptr->eptr = upper_32_bits(dma_addr);
>> }
> ...
>
> Maybe, but 'ptr' isn't a good choice.
>
>
Any suggestion ?

Christophe


\
 
 \ /
  Last update: 2015-04-17 19:01    [W:0.031 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site