Messages in this thread | | | Date | Wed, 15 Apr 2015 11:29:44 +0200 | From | Gregory CLEMENT <> | Subject | Re: [PATCH v2] genirq: Set IRQCHIP_SKIP_SET_WAKE flag for dummy_irq_chip |
| |
On 15/04/2015 10:14, Roger Quadros wrote: > Without this system suspend is broken on systems that have > drivers calling enable/disable_irq_wake() for interrupts based off > the dummy irq hook. > (e.g. drivers/gpio/gpio-pcf857x.c) > > http://article.gmane.org/gmane.linux.kernel/1879035 > > Signed-off-by: Roger Quadros <rogerq@ti.com>
FWIW:
Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> --- > kernel/irq/dummychip.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/irq/dummychip.c b/kernel/irq/dummychip.c > index 988dc58..2feb6fe 100644 > --- a/kernel/irq/dummychip.c > +++ b/kernel/irq/dummychip.c > @@ -57,5 +57,6 @@ struct irq_chip dummy_irq_chip = { > .irq_ack = noop, > .irq_mask = noop, > .irq_unmask = noop, > + .flags = IRQCHIP_SKIP_SET_WAKE, > }; > EXPORT_SYMBOL_GPL(dummy_irq_chip); >
-- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
| |