[lkml]   [2015]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] Fix pointer cast for 32 bits arch
Hi Peter,

On Mon, Apr 13, 2015 at 1:14 PM, Peter Senna Tschudin
<> wrote:
>> Perhaps checkpatch should complain about casts outside header files?
> Cocinelle found 664 double casts:
> and 9 triple casts:

I think double casts are only needed when casting between integers
and pointers of different sizes:
1. One cast to make the sizes match,
2. One cast to convert between pointer and integer.

I think triple casts can always be simplified.
Or am I missing some use cases?

> Those are 'not' patches, just the output of Coccinelle for analysis.
> The .cocci for triple cast:
> @@
> expression e1, e2;
> type t1, t2, t3;
> @@
> e1 =
> - (t1)(t2)(t3)
> e2
> So if there are cast patterns known to be wrong, it is easy to find
> and probably fix them with Coccinelle.

It depends on the original type and on the destination type.



Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

 \ /
  Last update: 2015-04-13 13:41    [W:0.103 / U:0.888 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site