lkml.org 
[lkml]   [2015]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] xtensa: Fix execdomain removal
On 04/12/2015 07:43 AM, Jeff Epler wrote:
> On Sat, Apr 11, 2015 at 07:19:51PM -0700, Guenter Roeck wrote:
>> The removal of exexdomain changes pointer offsets into the thread_info
>> structure.
> ...
>> -#define TI_EXEC_DOMAIN 0x00000004
>> -#define TI_FLAGS 0x00000008
>> +#define TI_FLAGS 0x00000004
>
> Hmm. If these have to be maintained by hand, perhaps they can be
> BUILD_BUG_ON'd in some appropriate C file? e.g.,
>
> BUILD_BUG_ON(TI_FLAGS != offsetof(struct thread_info, flags));
>
> Jeff
>
Other architectures use either DEFINE or OFFSET macros to define
those flags, so that would probably be a better solution if something
more fancy is asked for. That should probably be a separate patch,
though.

Guenter



\
 
 \ /
  Last update: 2015-04-12 17:41    [W:0.032 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site