Messages in this thread | | | Date | Fri, 10 Apr 2015 09:24:48 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v8] x86: mce: kexec: switch MCE handler for kexec/kdump |
| |
On Fri, Apr 10, 2015 at 04:07:26AM +0000, Naoya Horiguchi wrote: > ... wait, changing cpu_online_mask might confuse admins who try to > analyze the kdump, especially when the problems causing panic are CPU > related issues?
Well, if you're offlining the CPUs before doing the dump, you're already changing the system, aren't you? So why lie to people?
> In the similar way, changing tolerant value loses the original value, > although this is unlikely to be a problem. But if we change it, using > an upper bit to keep lowest 2 bit to save the original value is better?
I don't think that you need to do that - you can see from the original kernel's dmesg whether an MCE happened - we're normally very vocal. If the user tried to deliberately suppress that, then that's her fault only.
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply. --
| |