lkml.org 
[lkml]   [2015]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH net-next V3 13/23] ptp: igb: convert to the 64 bit get/set time methods.
    Date
    > -----Original Message-----
    > From: Richard Cochran [mailto:richardcochran@gmail.com]
    > Sent: Tuesday, March 31, 2015 2:37 PM
    > To: Keller, Jacob E
    > Cc: thomas.lendacky@amd.com; linux-kernel@vger.kernel.org;
    > baolin.wang@linaro.org; b45643@freescale.com; sshah@solarflare.com;
    > amirv@mellanox.com; ben@decadent.org.uk; sonic.zhang@analog.com;
    > peppe.cavallaro@st.com; Allan, Bruce W; rayagond@vayavyalabs.com;
    > tglx@linutronix.de; ariel.elior@qlogic.com; cmetcalf@ezchip.com; Vick,
    > Matthew; linux-net-drivers@solarflare.com; arnd@linaro.org;
    > Frank.Li@freescale.com; netdev@vger.kernel.org; mchan@broadcom.com;
    > Wyborny, Carolyn; prashant@broadcom.com; davem@davemloft.net;
    > Kirsher, Jeffrey T; stefan.sorensen@spectralink.com; john.stultz@linaro.org
    > Subject: Re: [PATCH net-next V3 13/23] ptp: igb: convert to the 64 bit
    > get/set time methods.
    >
    > On Tue, Mar 31, 2015 at 09:08:10PM +0000, Keller, Jacob E wrote:
    > > On Sun, 2015-03-29 at 23:12 +0200, Richard Cochran wrote:
    > > > For the 82576, the driver's clock is implemented using a timecounter,
    > > > and so with this patch that device is ready for the year 2038.
    > > >
    > > > However, in the case of the i210, the device stores the number of
    > > > seconds in a 32 bit register. Therefore, more work is needed on this
    > > > driver before the year 2038 comes around.
    > > >
    > > > Compile tested only.
    > >
    > > I assume we would want to use a time counter wrapper here to resolve
    > > this issue?
    >
    > I would just keep the seconds in software for settime() and adjtime(),
    > but let the nanoseconds field go to the hardware. Then, the gettime()
    > result, the periodic outputs, the external time stamps, and the skb
    > time stamps will need to be corrected by that many seconds.
    >
    > Thanks,
    > Richard

    That seems reasonable.

    Regards,
    Jake


    \
     
     \ /
      Last update: 2015-04-02 02:41    [W:5.302 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site