Messages in this thread | | | Date | Sat, 7 Mar 2015 10:57:47 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] regmap: introduce regmap_name to fix syscon regmap trace events |
| |
On Fri, Mar 06, 2015 at 03:16:55PM +0100, Philipp Zabel wrote:
> #include <linux/sort.h> > -#include <trace/events/regmap.h> > > #include "internal.h" > > +#include <trace/events/regmap.h> > +
The change is basically OK but the above is a bit too funky for my taste - it feels like it's asking for annoying compile breakage if anyone changes anything. I'd be more inclined to move the header somewhere where the events stuff can see it than do this. [unhandled content-type:application/pgp-signature] | |