lkml.org 
[lkml]   [2015]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] regmap: introduce regmap_name to fix syscon regmap trace events
On Fri, Mar 06, 2015 at 03:16:55PM +0100, Philipp Zabel wrote:

> #include <linux/sort.h>
> -#include <trace/events/regmap.h>
>
> #include "internal.h"
>
> +#include <trace/events/regmap.h>
> +

The change is basically OK but the above is a bit too funky for my
taste - it feels like it's asking for annoying compile breakage if
anyone changes anything. I'd be more inclined to move the header
somewhere where the events stuff can see it than do this.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-03-07 12:01    [W:0.142 / U:0.700 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site