lkml.org 
[lkml]   [2015]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RESEND] Staging: rtl8188eu: fix double unlock
On 03/07/2015 11:35 AM, Matteo Semenzato wrote:
> Il giorno sab, 07/03/2015 alle 11.28 -0600, Larry Finger ha scritto:
>> Have you actually tested this patch, or did you find this with some static checker?
>>
>> Larry
> The double unlock was found using smatch.

Are you really willing to test changes in locking based on a static checker? I
would not be so quick.

By the way, my reading of the documentation is that up releases the lock whereas
down sets it. Thus, I think your patch introduces a bug rather than fix one. I
agree that there is a mismatch, but I do not think your patch fixes anything.

Until this is actually tested on running code, NACK.

Larry




\
 
 \ /
  Last update: 2015-03-07 19:01    [W:0.033 / U:0.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site