Messages in this thread | | | Date | Thu, 5 Mar 2015 16:48:18 +1100 | From | NeilBrown <> | Subject | Re: [PATCH 04/15] twl4030_charger: use runtime_pm to keep usb phy active while charging. |
| |
On Wed, 25 Feb 2015 07:24:43 +0000 Lee Jones <lee.jones@linaro.org> wrote:
> On Tue, 24 Feb 2015, NeilBrown wrote: > > > The twl4030 usb phy needs to be active while we are using > > the USB VBUS as a current source for charging. > > In particular, the usb3v1 regulator must be enabled and the > > PHY_PWR_PHYPWD bit must be set to keep the phy powered. > > > > commit ab37813f4093a5f59cb8e083cde277289dc72ed3 > > twl4030_charger: Allow charger to control the regulator that feeds it > > > > Gave the charger control over the regulator, but didn't resolve > > the PHY_PWR_PHYPWD issue. > > > > Now that both of these are controlled by runtime_pm in > > phy-twl4030-usb, we can simply take a runtime_pm reference to the USB > > phy whenever the charger wants to use it as a current source. > > > > So this patch reverts the above commit, and adds the necessary > > runtime_pm calls. > > > > Signed-off-by: NeilBrown <neilb@suse.de> > > --- > > drivers/mfd/twl-core.c | 9 ++++----- > > Acked-by: Lee Jones <lee.jones@linaro.org>
Thanks. I guess that clear it to go in though the 'power supply' tree.
NeilBrown [unhandled content-type:application/pgp-signature] | |