lkml.org 
[lkml]   [2015]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 07/38] perf tools: Handle indexed data file properly
    On Tue, Mar 03, 2015 at 12:07:19PM +0900, Namhyung Kim wrote:
    > When perf detects data file has index table, process header part first
    > and then rest data files in a row. Note that the indexed sample data is
    > recorded for each cpu/thread separately, it's already ordered with
    > respect to themselves so no need to use the ordered event queue
    > interface.
    >
    > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
    > ---
    > tools/perf/util/session.c | 62 ++++++++++++++++++++++++++++++++++++++---------
    > tools/perf/util/session.h | 5 ++++
    > 2 files changed, 55 insertions(+), 12 deletions(-)
    >
    > diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
    > index e4f166981ff0..00cd1ad427be 100644
    > --- a/tools/perf/util/session.c
    > +++ b/tools/perf/util/session.c
    > @@ -1300,11 +1300,10 @@ fetch_mmaped_event(struct perf_session *session,
    > #define NUM_MMAPS 128
    > #endif
    >
    > -static int __perf_session__process_events(struct perf_session *session,
    > +static int __perf_session__process_events(struct perf_session *session, int fd,
    > u64 data_offset, u64 data_size,
    > u64 file_size, struct perf_tool *tool)
    > {
    > - int fd = perf_data_file__fd(session->file);

    why is 'fd' passed separatelly here? we have single file now
    and the only 'file::fd' we use is in session, no?

    I might be missing some change in later patches ;-)

    jirka


    \
     
     \ /
      Last update: 2015-03-04 17:41    [W:3.809 / U:0.356 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site