Messages in this thread | | | Date | Wed, 4 Mar 2015 06:38:53 -0800 | From | Bjorn Andersson <> | Subject | Re: [PATCH v2 2/2] pinctrl: qcom: handle input-enable pinconf property |
| |
On Wed 04 Mar 02:41 PST 2015, Stanimir Varbanov wrote:
> This enables support of 'input-enable' pinconf generic property in > the pinctrl driver. > > Signed-off-by: Stanimir Varbanov <svarbanov@mm-sol.com> > --- > drivers/pinctrl/qcom/pinctrl-msm.c | 11 +++++++++++ > 1 files changed, 11 insertions(+), 0 deletions(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c > index d36e511..f3d800f 100644 > --- a/drivers/pinctrl/qcom/pinctrl-msm.c > +++ b/drivers/pinctrl/qcom/pinctrl-msm.c > @@ -193,6 +193,7 @@ static int msm_config_reg(struct msm_pinctrl *pctrl, > *mask = 7; > break; > case PIN_CONFIG_OUTPUT: > + case PIN_CONFIG_INPUT_ENABLE: > *bit = g->oe_bit; > *mask = 1; > break; > @@ -260,6 +261,12 @@ static int msm_config_group_get(struct pinctrl_dev *pctldev, > val = readl(pctrl->regs + g->io_reg); > arg = !!(val & BIT(g->in_bit)); > break; > + case PIN_CONFIG_INPUT_ENABLE: > + /* Pin is output */ > + if (arg) > + return -EINVAL; > + arg = 1; > + break;
I still don't like this part of the api, but the patch is
Acked-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> default: > return -ENOTSUPP; > }
Regards, Bjorn
| |