Messages in this thread | | | Date | Wed, 04 Mar 2015 12:43:57 +0100 | From | Daniel Lezcano <> | Subject | Re: [PATCH v2 5/5] clocksource: sun5i: Add clock notifiers |
| |
On 03/04/2015 10:32 AM, Maxime Ripard wrote: > On Tue, Mar 03, 2015 at 12:16:57PM +0100, Daniel Lezcano wrote: >> On 03/03/2015 09:52 AM, Maxime Ripard wrote: >>> On Mon, Jan 26, 2015 at 03:35:41PM +0100, Maxime Ripard wrote: >>>>>> +static int sun5i_rate_cb_clksrc(struct notifier_block *nb, >>>>>> + unsigned long event, void *data) >>>>>> +{ >>>>>> + struct clk_notifier_data *ndata = data; >>>>>> + struct sun5i_timer *timer = to_sun5i_timer(nb); >>>>>> + struct sun5i_timer_clksrc *cs = container_of(timer, >>>>>> + struct sun5i_timer_clksrc, timer); >>>>>> + >>>>>> + switch (event) { >>>>>> + case PRE_RATE_CHANGE: >>>>>> + clocksource_unregister(&cs->clksrc); >>>>>> + break; >>>>>> + >>>>>> + case POST_RATE_CHANGE: >>>>>> + clocksource_register_hz(&cs->clksrc, ndata->new_rate); >>>>>> + break; >>>>> >>>>> Why clocksource_unregister couldn't be in the POST_RATE_CHANGE ? >>>> >>>> Wouldn't that leave a (small, I agree) window where the timer would >>>> run at a rate different to the one it has been registered with? >>> >>> Ping? >> >> Hi Maxime, >> >> except I missed something, there were a couple of comments and I was waiting >> a V3. > > Indeed, but one of these comments (the one above) was still under > discussion.
Ah, yeah. Fair enough :)
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |