lkml.org 
[lkml]   [2015]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.14 01/73] Bluetooth: ath3k: workaround the compatibility issue with xHCI controller
    Date
    3.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Adam Lee <adam.lee@canonical.com>

    commit c561a5753dd631920c4459a067d22679b3d110d6 upstream.

    BugLink: https://bugs.launchpad.net/bugs/1400215

    ath3k devices fail to load firmwares on xHCI buses, but work well on
    EHCI, this might be a compatibility issue between xHCI and ath3k chips.
    As my testing result, those chips will work on xHCI buses again with
    this patch.

    This workaround is from Qualcomm, they also did some workarounds in
    Windows driver.

    Signed-off-by: Adam Lee <adam.lee@canonical.com>
    Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/bluetooth/ath3k.c | 8 ++++++++
    1 file changed, 8 insertions(+)

    --- a/drivers/bluetooth/ath3k.c
    +++ b/drivers/bluetooth/ath3k.c
    @@ -157,6 +157,8 @@ static const struct usb_device_id ath3k_
    #define USB_REQ_DFU_DNLOAD 1
    #define BULK_SIZE 4096
    #define FW_HDR_SIZE 20
    +#define TIMEGAP_USEC_MIN 50
    +#define TIMEGAP_USEC_MAX 100

    static int ath3k_load_firmware(struct usb_device *udev,
    const struct firmware *firmware)
    @@ -187,6 +189,9 @@ static int ath3k_load_firmware(struct us
    count -= 20;

    while (count) {
    + /* workaround the compatibility issue with xHCI controller*/
    + usleep_range(TIMEGAP_USEC_MIN, TIMEGAP_USEC_MAX);
    +
    size = min_t(uint, count, BULK_SIZE);
    pipe = usb_sndbulkpipe(udev, 0x02);
    memcpy(send_buf, firmware->data + sent, size);
    @@ -283,6 +288,9 @@ static int ath3k_load_fwfile(struct usb_
    count -= size;

    while (count) {
    + /* workaround the compatibility issue with xHCI controller*/
    + usleep_range(TIMEGAP_USEC_MIN, TIMEGAP_USEC_MAX);
    +
    size = min_t(uint, count, BULK_SIZE);
    pipe = usb_sndbulkpipe(udev, 0x02);




    \
     
     \ /
      Last update: 2015-03-04 09:41    [W:4.057 / U:0.528 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site