lkml.org 
[lkml]   [2015]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.18 045/151] power: bq24190: Fix ignored supplicants
    Date
    3.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Krzysztof Kozlowski <k.kozlowski@samsung.com>

    commit 478913fdbdfd4a781d91c993eb86838620fe7421 upstream.

    The driver mismatched 'num_supplicants' with 'num_supplies' of
    power_supply structure.

    It provided list of supplicants (power_supply.supplied_to) but did
    not set the number of supplicants. Instead it set the num_supplies which
    is used when iterating over number of supplies (power_supply.supplied_from).

    As a result the list of supplicants was ignored by core because its size
    was 0.

    Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
    Fixes: d7bf353fd0aa ("bq24190_charger: Add support for TI BQ24190 Battery Charger")
    Signed-off-by: Sebastian Reichel <sre@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/power/bq24190_charger.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/power/bq24190_charger.c
    +++ b/drivers/power/bq24190_charger.c
    @@ -929,7 +929,7 @@ static void bq24190_charger_init(struct
    charger->properties = bq24190_charger_properties;
    charger->num_properties = ARRAY_SIZE(bq24190_charger_properties);
    charger->supplied_to = bq24190_charger_supplied_to;
    - charger->num_supplies = ARRAY_SIZE(bq24190_charger_supplied_to);
    + charger->num_supplicants = ARRAY_SIZE(bq24190_charger_supplied_to);
    charger->get_property = bq24190_charger_get_property;
    charger->set_property = bq24190_charger_set_property;
    charger->property_is_writeable = bq24190_charger_property_is_writeable;



    \
     
     \ /
      Last update: 2015-03-04 09:21    [W:4.041 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site