lkml.org 
[lkml]   [2015]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/2] make automatic device_id generation possible
    On (03/05/15 10:17), Minchan Kim wrote:
    > >
    > >
    > > user defined id support comes at a price of ~10 lines of code, or even
    > > less. we waste much more code to show ->stats, and not all of them are
    > > of any real use, to be fair. that just said, that dropping user defined
    > > id is not a great deal. ok, let's see if we can come up with anything by
    > > the end of this day and I'll send out a removal patch if nothing pop up.
    >
    > As I told you, I'm never against. I just want to know usecase.
    > If we don't support it from the beginnig, someday, someone will complain
    > and we can catch up the usecase and support it easily with adding 10 line code.
    >

    sure, no problem. that's a good question -- should we support user
    defined ids or not. thanks for asking.

    I can imagine that that static num_devices limitation (along with max
    num_devices == 32) was sort of a show stopper for some users (or an
    unnecessary complication at least), like in 'my now favorite' build
    server example :)

    -ss

    > This dyanmic add/revmove feature proves the idea. :)
    > Main reason I finally decided dynamic device management feature was
    > someone complained he should do rmmod/insmod zram.ko to increase
    > the number of zram device in runtime but one of zram device was
    > used for swap, which was hard to swapoff due to small memory
    > so there was no way to increase the number of zram device.
    > It appeals a lot to support dynamic zram creating and finally I catch up
    > the usecase. ;-)
    >


    \
     
     \ /
      Last update: 2015-03-05 02:41    [W:4.365 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site