lkml.org 
[lkml]   [2015]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.19 094/175] TPM: Add new TPMs to the tail of the list to prevent inadvertent change of dev
    Date
    3.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: David Howells <dhowells@redhat.com>

    commit 398a1e71dc827b994b7f2f56c7c2186fea7f8d75 upstream.

    Add newly registered TPMs to the tail of the list, not the beginning, so that
    things that are specifying TPM_ANY_NUM don't find that the device they're
    using has inadvertently changed. Adding a second device would break IMA, for
    instance.

    Signed-off-by: David Howells <dhowells@redhat.com>
    Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
    Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/char/tpm/tpm-interface.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/char/tpm/tpm-interface.c
    +++ b/drivers/char/tpm/tpm-interface.c
    @@ -1122,7 +1122,7 @@ struct tpm_chip *tpm_register_hardware(s

    /* Make chip available */
    spin_lock(&driver_lock);
    - list_add_rcu(&chip->list, &tpm_chip_list);
    + list_add_tail_rcu(&chip->list, &tpm_chip_list);
    spin_unlock(&driver_lock);

    return chip;



    \
     
     \ /
      Last update: 2015-03-04 07:41    [W:6.881 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site