Messages in this thread | | | Subject | Re: [PATCH net-next] ethernet: Use bool function returns of true/false instead of 1/0 | From | Joe Perches <> | Date | Tue, 31 Mar 2015 12:49:31 -0700 |
| |
(shortened cc list)
On Tue, 2015-03-31 at 13:10 +0200, Michal Simek wrote: > On 03/30/2015 03:25 AM, Joe Perches wrote: > > Use bool constants as the return values instead of 1 and 0. [] > > diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c > > index 2111b91..6008eee 100644 > > --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c > > +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c > > @@ -1062,7 +1062,7 @@ static bool get_bool(struct platform_device *ofdev, const char *s) > > } else { > > dev_warn(&ofdev->dev, "Parameter %s not found," > > "defaulting to false\n", s); > > - return 0; > > + return false; > > } > > } > > Kernel-doc should be also fixed in spite of this whole function is just > broken and binding should be fixed to use of_property_read_bool for > these properties.
Hi Michal.
David's applied this so if you or Sören want to fix up the function and kernel-doc to your taste, please do.
cheers, Joe
| |