Messages in this thread | | | Date | Tue, 31 Mar 2015 21:39:02 +0530 | From | Kishon Vijay Abraham I <> | Subject | Re: [PATCH 1/2] phy: spear1310-miphy: Return proper error for spear1310_miphy_xlate |
| |
Hi,
On Wednesday 25 March 2015 02:31 PM, Axel Lin wrote: > The of_xlate callback should return ERR_PTR on error. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- > drivers/phy/phy-spear1310-miphy.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/phy-spear1310-miphy.c b/drivers/phy/phy-spear1310-miphy.c > index 9f47fae..4684b04 100644 > --- a/drivers/phy/phy-spear1310-miphy.c > +++ b/drivers/phy/phy-spear1310-miphy.c > @@ -192,14 +192,14 @@ static struct phy *spear1310_miphy_xlate(struct device *dev, > > if (args->args_count < 1) { > dev_err(dev, "DT did not pass correct no of args\n"); > - return NULL; > + return ERR_PTR(-EINVAL);
It should actually be -ENODEV so that phy_optional_get() doesn't fail. > } > > priv->mode = args->args[0]; > > if (priv->mode != SATA && priv->mode != PCIE) { > dev_err(dev, "DT did not pass correct phy mode\n"); > - return NULL; > + return ERR_PTR(-EINVAL);
Same here.
Thanks Kishon
| |