lkml.org 
[lkml]   [2015]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC/RFT, RESEND] powerpc: move cacheinfo sysfs to generic cacheinfo infrastructure
Date
On Mon, 2015-23-02 at 18:18:20 UTC, Sudeep Holla wrote:
> This patch removes the redundant sysfs cacheinfo code by reusing
> the newly introduced generic cacheinfo infrastructure through the
> commit 246246cbde5e ("drivers: base: support cpu cache information
> interface to userspace via sysfs")
>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Anshuman Khandual <khandual@linux.vnet.ibm.com>
> Cc: linuxppc-dev@lists.ozlabs.org
> ---
> arch/powerpc/kernel/cacheinfo.c | 811 +++++-----------------------------------
> arch/powerpc/kernel/cacheinfo.h | 8 -
> arch/powerpc/kernel/sysfs.c | 12 +-
> 3 files changed, 91 insertions(+), 740 deletions(-)
> delete mode 100644 arch/powerpc/kernel/cacheinfo.h
>
> Hi,
>
> This patch is not tested. Last time Anshuman tested, he had seen issues.
> The core driver has changed a lot after that. Since PPC depends a lot
> on DT for cache information, there might be issues in the core later
> which I could not identify with ARM/ARM64. It would be much appreciable
> if someone help me in testing and fixing those so that PPC can migrate
> to new/common cacheinfo infrastructure. This resend is rebased on v4.0-rc1

Doesn't build for me.

arch/powerpc/platforms/pseries/suspend.c:29:36: fatal error: ../../kernel/cacheinfo.h: No such file or directory
#include "../../kernel/cacheinfo.h"

Anshuman must have worked around that somehow to test it previously?

Removing the include doesn't fix it, it needs cacheinfo_cpu_on/offline().

cheers


\
 
 \ /
  Last update: 2015-03-31 13:21    [W:0.126 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site